Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self update composer in the image we use to prepare the code in CI #1221

Merged
merged 2 commits into from
May 11, 2021

Conversation

labbati
Copy link
Member

@labbati labbati commented Apr 28, 2021

Description

Due to:

Note, we wait for composer images to be released on docker hub before rebuilding the development images.
We do not use composer in other images used to build the final artifact.

Readiness checklist

  • [ ] (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati added this to the 0.59.0 milestone Apr 28, 2021
@labbati labbati modified the milestones: 0.59.0, 0.60.0 May 5, 2021
@morrisonlevi
Copy link
Collaborator

@labbati I approved this a week ago -- do you not want to merge it?

@labbati
Copy link
Member Author

labbati commented May 11, 2021

Good point 😄 thanks

@labbati labbati merged commit 721afc4 into master May 11, 2021
@labbati labbati deleted the labbati/composer branch May 11, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants