Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a way to detect Zend Memory Manager leak messages in the ZAI tests by grepping the test log in CI for:
There were a few ZMM leaks that were isolated to the tests (the leaks were not in the tracer or any production code paths) and those are fixed in d8b4c3e.
Ideally the leak detection would be implemented as part of the ZAI SAPI test runner, but every way I tired to implement it, I hit a blocker.
ZmmLeakListener
. The event listener works, buttestCaseStats.stdOut
andtestCaseStats.stdErr
are always empty fromtestCaseEnded
.junit
, the customZmmLeakListener
still cannot access ZAI SAPI stdout and stderr.write
tofwrite
does not seem to make any difference.junit
,<system-out/>
and<system-err/>
are always empty.That leaves me with "manually" grepping the test log for the ZMM leak message in CI. I'm probably missing something obvious with the Catch2 setup, so if anyone else can figure out a better solution to this, I'd love to know your thoughts.
Reviewer checklist