Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate "innerhook" from trace_method and trace_function #1240

Merged
merged 1 commit into from
May 20, 2021
Merged

Eliminate "innerhook" from trace_method and trace_function #1240

merged 1 commit into from
May 20, 2021

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented May 20, 2021 •
edited by SammyK

Description

innerhook is now unneeded and can be removed.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests adapted for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi
Eliminate innerhook
4e994d9 
Legacy functionality

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from SammyK May 20, 2021 08:47
@bwoebi bwoebi added this to the 0.60.0 milestone May 20, 2021
@bwoebi bwoebi changed the title Eliminate innerhook Eliminate "innerhook" from trace_method and trace_function May 20, 2021
@SammyK SammyK added the 🏆 enhancement A new feature or improvement label May 20, 2021
SammyK
SammyK approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for knocking this out @bwoebi! 👍

@bwoebi bwoebi merged commit fd230df into master May 20, 2021
@bwoebi bwoebi deleted the bob/apmpphp-376-remove-innerhook branch May 20, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
🏆 enhancement A new feature or improvement
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwoebi @SammyK