Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred loading with ZAI function-call seam (PHP 8) #1243

Merged
merged 1 commit into from
May 26, 2021
Merged

Deferred loading with ZAI function-call seam (PHP 8) #1243

merged 1 commit into from
May 26, 2021

Conversation

SammyK
Copy link
Contributor

@SammyK SammyK commented May 20, 2021 •
edited by bwoebi

Description

This uses the ZAI function-call seam added in #1234 to call the userland deferred loader function DDTrace\Integrations\load_deferred_integration.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug. Uses the exiting deferred-loader tests.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@SammyK SammyK added the c-extension Apply this label to issues and prs related to the C-extension label May 20, 2021
@SammyK SammyK added this to the 0.60.0 milestone May 20, 2021
@SammyK SammyK marked this pull request as ready for review May 20, 2021 19:50
Base automatically changed from sammyk/php8/zai/function-call to master May 25, 2021 16:43
@SammyK SammyK force-pushed the sammyk/php8/zai/deferred-loader branch from e908f83 to 2fb9157 Compare May 25, 2021 16:50
bwoebi
bwoebi approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems to be just moving code up, and replacing sandbox+zend_fcall bei zai_fcall, looks straightforward and correct to me.

@labbati
Copy link
Member

labbati commented May 26, 2021

Test failures are not related to this PR, merging it.

@labbati labbati merged commit 6050ff0 into master May 26, 2021
@labbati labbati deleted the sammyk/php8/zai/deferred-loader branch May 26, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
c-extension Apply this label to issues and prs related to the C-extension
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SammyK @labbati @bwoebi