Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mapping-settings to be deserialized as a zend_array * #1253

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Move mapping-settings to be deserialized as a zend_array * #1253

merged 1 commit into from
Jun 8, 2021

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jun 8, 2021 •
edited by SammyK

Required for the internal spans, as they'll need to access these.

Split out from #1251.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug. (Covered by the changed tests)

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added the c-extension Apply this label to issues and prs related to the C-extension label Jun 8, 2021
@bwoebi bwoebi added this to the 0.61.0 milestone Jun 8, 2021
@bwoebi
Move mapping-settings to be deserialized as a zend_array *
be3a757 
Required for the internal spans, as they'll need to access these.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from SammyK June 8, 2021 16:50
SammyK
SammyK approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for splitting this out @bwoebi! We'll migrate this into ZAI config.

@bwoebi bwoebi merged commit fe830c0 into master Jun 8, 2021
@bwoebi bwoebi deleted the bob/hash-config branch June 8, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
c-extension Apply this label to issues and prs related to the C-extension
Projects
None yet
Milestone
0.61.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwoebi @SammyK