Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run mongodb-driver testsuite in CI with and without the tracer #1255

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Run mongodb-driver testsuite in CI with and without the tracer #1255

merged 1 commit into from
Jun 11, 2021

Conversation

labbati
Copy link
Member

@labbati labbati commented Jun 10, 2021 •
edited by SammyK

Description

Run the latest mongodb-drive testsuite in CI (https://github.com/mongodb/mongo-php-driver).

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati added the 🏆 enhancement A new feature or improvement label Jun 10, 2021
@labbati labbati added this to the 0.61.0 milestone Jun 10, 2021
@labbati labbati added dev/testing and removed 🏆 enhancement A new feature or improvement labels Jun 10, 2021
@labbati labbati force-pushed the labbati/mongodb-driver-testsuite branch from 4586aab to 72b2d02 Compare June 10, 2021 13:20
SammyK
SammyK approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-06-11 at 11 26 25 AM

LGTM! 👍 Thanks @labbati; ext/mongodb here we come!

@labbati
Copy link
Member Author

labbati commented Jun 11, 2021

Thanks @SammyK

@labbati labbati merged commit d9ad858 into master Jun 11, 2021
@labbati labbati deleted the labbati/mongodb-driver-testsuite branch June 11, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
dev/testing
Projects
None yet
Milestone
0.61.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@labbati @SammyK