Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system tests in CI #1552

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add system tests in CI #1552

merged 1 commit into from
Apr 5, 2022

Conversation

cbeauchesne
Copy link
Collaborator

Description

Add System tests in CI (doc).

System tests is a functional test suite that performs end-to-end testing on our customer products. It spawns a tracer, an agent, some proxies to spy traffic between all components, run a typical scenario and checks that everything happen as expected.

Goals

  • Having a unique tests suite for all tracers
  • good to catch integration bugs and everything that happen in real life.
  • fast (5 mn for build step, 2:30 minutes for test step), and adding new test case is almost free.
  • free from flakiness, so you can rely on failure on test step. If you have any doubt, please reach us on slack channel libraries-system-tests.
  • easy to run locally

Non-goals

  • provide a detailled explanation of issues : it's black box testing, so we'll describe what we expected and what we saw, but we don't have access to component's internals, so you'll need to investigate to understand the root cause.
  • crawling a context matrix : as now we support apache and php-fpm. We can add other framework, or idiomatic versions. But it's not meant to do smoke test on all possible OS/framework versions (or at least, it'll ask you some effort, for probably a bad return on investment).
  • performance testing

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
    • NA
  • Tests added for this feature/bug. NA
    • NA

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/system-tests branch 2 times, most recently from 5bedd32 to 10ece88 Compare March 30, 2022 09:06
@cbeauchesne cbeauchesne marked this pull request as ready for review March 30, 2022 10:04
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cbeauchesne, very nice to see system tests in PHP.

Note: test failures are not related to this PR.

@labbati labbati merged commit fa2245f into master Apr 5, 2022
@labbati labbati deleted the cbeauchesne/system-tests branch April 5, 2022 08:03
@labbati labbati added this to the 0.72.0 milestone Apr 5, 2022
@labbati labbati mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants