Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdbinit files for php 8.0 and 8.1 #1556

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add gdbinit files for php 8.0 and 8.1 #1556

merged 1 commit into from
Apr 5, 2022

Conversation

labbati
Copy link
Member

@labbati labbati commented Apr 1, 2022

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati added this to the 0.72.0 milestone Apr 1, 2022
@bwoebi
Copy link
Collaborator

bwoebi commented Apr 1, 2022

What do you need these for? As in, when isn't it enough to do source /usr/local/src/php/.gdbinit in gdb in our containers?

@labbati
Copy link
Member Author

labbati commented Apr 5, 2022

For cases when you have not PHP's sources, but you mount dd-trace-php, e.g. our dd-trace-php-solutions repo, randomized tests and rel-env images.

If we want to remove them it is not a big deal (I can wget them, no problem) but we should either remove them for all versions in that folder or to have them for all versions.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we already have existing gdbinit files (never seen those), then it's a no-brainer :-)

@labbati labbati merged commit e343bdb into master Apr 5, 2022
@labbati labbati deleted the labbati/gdbinit branch April 5, 2022 10:29
@labbati
Copy link
Member Author

labbati commented Apr 5, 2022

Thanks

@labbati labbati mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants