Fix #1544: Handle hook dummy span hack when assigning parent #1557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1544. The dummy span hack of hooks strikes again.
To expand on that: in our current implementation of hook_function we install a dummy span. This dummy span must never be exposed to userland. This fixes this span being exposed via the parent property.
Once we merge our new hooks implementation no such span will exist anymore and this hack of skipping that span can be removed.
Readiness checklist
Reviewer checklist