Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flex to v1.18.5 in composer.lock files for Symfony 4.0 and 5.0 #1560

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 5, 2022

Description

The newer flex version check against the existence of the manifest key instead of failing outright when it is missing.

This fixes our test_web_symfony runners.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

The newer flex version check against the existence of the manifest key instead of failing outright when it is missing.
Fixes our test_web_symfony runners.
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a mystery to me how this can fix the issue, since in theory we do composer update and not composer install (and we do not restore the vendor directory as far as I know). But if that work let's merge it.

@labbati
Copy link
Member

labbati commented Apr 5, 2022

What I just wrote is not true for symfony 4.0

dd-trace-php/Makefile

Lines 993 to 997 in e343bdb

# We hit broken updates in this unmaintained version, so we committed a
# working composer.lock and we composer install instead of composer update
$(COMPOSER) --working-dir=tests/Frameworks/Symfony/Version_4_0 install
php tests/Frameworks/Symfony/Version_4_0/bin/console cache:clear --no-warmup --env=prod
$(call run_tests,tests/Integrations/Symfony/V4_0)
so go and ship it

@bwoebi bwoebi merged commit aa4e129 into master Apr 5, 2022
@bwoebi bwoebi deleted the bob/debug-composer branch April 5, 2022 12:41
@labbati labbati added this to the 0.72.0 milestone Apr 5, 2022
@labbati labbati mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants