Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-6420] bump env_logger to 0.9.3 #1804

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Nov 17, 2022

Description

This fixes the

warning: use of deprecated tuple variant `env_logger::Target::Pipe`: This functionality is [broken](https://github.com/env-logger-rs/env_logger/issues/208) and nobody is working on fixing it
  --> src/logging.rs:23:29
   |
23 |             .target(Target::Pipe(target))
   |                             ^^^^
   |
   = note: `#[warn(deprecated)]` on by default

during cargo build

See: rust-cli/env_logger#208

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl marked this pull request as ready for review November 18, 2022 07:14
@realFlowControl realFlowControl requested a review from a team as a code owner November 18, 2022 07:14
@realFlowControl realFlowControl force-pushed the florian/PROF-6420-update-env-logger branch from 43e746e to 501293c Compare November 18, 2022 11:11
@realFlowControl realFlowControl added the profiling Relates to the Continuous Profiler label Nov 22, 2022
@realFlowControl realFlowControl added this to the 0.82.0 milestone Nov 22, 2022
@realFlowControl realFlowControl added the 🏆 enhancement A new feature or improvement label Nov 22, 2022
@realFlowControl realFlowControl merged commit d5c6e2c into master Nov 22, 2022
@realFlowControl realFlowControl deleted the florian/PROF-6420-update-env-logger branch November 22, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏆 enhancement A new feature or improvement profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants