Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config mode to datadog-setup.php #1951

Merged
merged 47 commits into from
Apr 27, 2023

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Mar 1, 2023

Description

This PR will add a config mode to the datadog-setup.php, see PROF-6905

  • adds an implementation of getopt() that allows for commands
  • adds a config get, config set and config list command
  • updates the help output

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl self-assigned this Mar 1, 2023
@realFlowControl realFlowControl added 🏆 enhancement A new feature or improvement cat:configuration An issue while trying to configure the tracer labels Mar 1, 2023
@realFlowControl realFlowControl force-pushed the florian/PROF-6905-add-config-mode branch 2 times, most recently from dd986fa to afc61b0 Compare March 1, 2023 15:59
@realFlowControl realFlowControl force-pushed the florian/PROF-6905-add-config-mode branch from afc61b0 to fc40344 Compare March 10, 2023 13:14
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't finish the review right now, but it's looking good so far!

datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
@realFlowControl realFlowControl added this to the 0.86.0 milestone Mar 20, 2023
@morrisonlevi morrisonlevi changed the title (feat) add config mode to datadog-setup.php feat: add config mode to datadog-setup.php Mar 20, 2023
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR does a good job at handling all the possible cases :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:configuration An issue while trying to configure the tracer 🏆 enhancement A new feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants