Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(profiling) add a test to ensure we do not crash with fibers #2003

Merged
merged 1 commit into from
Apr 6, 2023
Merged

test(profiling) add a test to ensure we do not crash with fibers #2003

merged 1 commit into from
Apr 6, 2023

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Apr 5, 2023 •
edited

Description

This will add a .phpt test to ensure we are not crashing with fibers being used.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl added dev/testing profiling Relates to the Continuous Profiler labels Apr 5, 2023
@realFlowControl realFlowControl added this to the 0.87.0 milestone Apr 5, 2023
@realFlowControl realFlowControl requested a review from a team as a code owner April 5, 2023 13:31
@realFlowControl realFlowControl self-assigned this Apr 5, 2023
@realFlowControl realFlowControl changed the title test(profiling) ensure we do not crash with fibers test(profiling) add a test to ensure we do not crash with fibers Apr 5, 2023
r1viollet
r1viollet approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the new test coverage!

@realFlowControl realFlowControl merged commit c7e88ac into master Apr 6, 2023
@realFlowControl realFlowControl deleted the florian/PROF-7383-ensure-no-crash-with-fibers branch April 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r1viollet r1viollet r1viollet approved these changes

Assignees

@realFlowControl realFlowControl

Labels
dev/testing profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realFlowControl @r1viollet