Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for consuming an array via DDTrace\consume_distributed_tracing_headers #2010

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Allow for consuming an array via DDTrace\consume_distributed_tracing_headers #2010

merged 1 commit into from
Apr 11, 2023

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 11, 2023

Description

This should be much more straightforward when generating headers to later consume them when doing manual injection and extraction.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi
Allow for consuming an array via DDTrace\consume_distributed_tracing_…
6ddd29e 
…headers

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi added this to the 0.87.0 milestone Apr 11, 2023
@bwoebi bwoebi requested a review from a team as a code owner April 11, 2023 13:34
pierotibou
pierotibou approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Even though my review of the C code may not be fully trusted :)

@bwoebi bwoebi merged commit 4c987f0 into master Apr 11, 2023
@bwoebi bwoebi deleted the bob/array-api-consume_distributed_tracing_headers branch April 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotibou pierotibou pierotibou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwoebi @pierotibou