Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement replacing of return values #2018

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 19, 2023

Description

Adding HookData->overrideReturnValue.

Needed for Laravel Queues implementation to inject distributed tracing data.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.87.0 milestone Apr 19, 2023
@bwoebi bwoebi requested a review from a team as a code owner April 19, 2023 13:35
Copy link
Collaborator

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

Base automatically changed from bob/fix-by-ref-install-hook to master April 20, 2023 13:26
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 3671b83 into master Apr 21, 2023
@bwoebi bwoebi deleted the bob/replace-retval-hook branch April 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants