Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2012: Remove PHP 7-only types from signatures #2021

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix #2012: Remove PHP 7-only types from signatures #2021

merged 2 commits into from
Apr 21, 2023

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 21, 2023

Description

And adding a CI check for that...

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.87.0 milestone Apr 21, 2023
@bwoebi bwoebi requested a review from a team as a code owner April 21, 2023 09:15
PROFeNoM
PROFeNoM approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'll be easier to spot that kind of issues from now on :)

labbati
labbati approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwoebi bwoebi merged commit 530afad into master Apr 21, 2023
@bwoebi bwoebi deleted the bob/fix-2012 branch April 21, 2023 17:58
@dserodio dserodio mentioned this pull request May 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwoebi @labbati @PROFeNoM