Add SQLSRV Integration #2031
Merged
Add SQLSRV Integration #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The sha256 for the buster images weren't the one I'd expect (not the same as the latest versions)
This reverts commit 52d44ee.
pierotibou
approved these changes
May 2, 2023
|
|
||
| $integration->detectError($hook->returned, $span); | ||
| }); | ||
| } else { |
There was a problem hiding this comment.
In theory, as we're only in maintenance mode for PHP5, you didn't have to do this. But no worries if it is done now
There was a problem hiding this comment.
(It just has no effect on PHP 5 as it's not declared in the IntegrationsLoader for PHP 5)
bwoebi
reviewed
May 5, 2023
bwoebi
reviewed
May 5, 2023
bwoebi
reviewed
May 5, 2023
bwoebi
reviewed
May 5, 2023
|
|
||
| protected function setMetricNumRows(SpanData $span, $stmt) | ||
| { | ||
| if ($stmt) { |
There was a problem hiding this comment.
If there's no num_rows, can you please assign sqlsrv_rows_affected() to db.row_count? (like in the PDO integration, where both are merged into the same function incidentally; the mysqlintegration is a bit wrong on that.)
bwoebi
approved these changes
May 5, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a SQLSRV Integration. Moreover, it will change the buster dockerfiles to include the required drivers (these images have already been pushed to datadog/dd-trace-ci)
Readiness checklist
Reviewer checklist