Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(profiling): raise sampling distance for allocations #2036

Merged
merged 3 commits into from
May 5, 2023
Merged

perf(profiling): raise sampling distance for allocations #2036

merged 3 commits into from
May 5, 2023

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented May 5, 2023 •
edited by morrisonlevi

Description

This PR will raise the sampling distance for allocation profiling from 512 KB to 2048 KB to prepare for GAing. This lowers how often stacks are walked, reducing performance overhead for allocation profiling.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl added 🏆 enhancement A new feature or improvement profiling Relates to the Continuous Profiler labels May 5, 2023
@realFlowControl realFlowControl added this to the 0.87.0 milestone May 5, 2023
@realFlowControl realFlowControl self-assigned this May 5, 2023
@realFlowControl realFlowControl requested a review from a team as a code owner May 5, 2023 14:03
@realFlowControl realFlowControl changed the title feat(profiling) GA allocation profiling feat(profiling) raise sampling distance for allocation profiling May 5, 2023
@morrisonlevi morrisonlevi merged commit c26f712 into master May 5, 2023
298 of 342 checks passed
@morrisonlevi morrisonlevi deleted the florian/ga-allocation-profiling branch May 5, 2023 15:49
@morrisonlevi morrisonlevi changed the title feat(profiling) raise sampling distance for allocation profiling perf(profiling): raise sampling distance for allocations May 5, 2023
@morrisonlevi morrisonlevi added Overhead Relates to latency, CPU, or memory overhead and removed 🏆 enhancement A new feature or improvement labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees

@realFlowControl realFlowControl

Labels
Overhead Relates to latency, CPU, or memory overhead profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@realFlowControl @morrisonlevi