Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiling): crashes when allocation sampling occurs in certain places #2039

Merged
merged 3 commits into from
May 8, 2023
Merged

fix(profiling): crashes when allocation sampling occurs in certain places #2039

merged 3 commits into from
May 8, 2023

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented May 8, 2023 •
edited

Description

In preparing allocation profiling GA we found some bugs in the profiler -> tracer interaction that this PR fixes.

  • possible segfault when instrumenting curl_setopt() in PHP7
  • possible segfault when fetching active span during priority sampling decision

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl added the profiling Relates to the Continuous Profiler label May 8, 2023
@realFlowControl realFlowControl added this to the 0.87.0 milestone May 8, 2023
@realFlowControl realFlowControl requested a review from a team as a code owner May 8, 2023 13:18
@realFlowControl realFlowControl self-assigned this May 8, 2023
@morrisonlevi morrisonlevi changed the title tests: enable allocation profiling in randomized tests fix(profiling): crashes when sampling occurs in certain places May 8, 2023
@morrisonlevi morrisonlevi changed the title fix(profiling): crashes when sampling occurs in certain places fix(profiling): crashes when allocation sampling occurs in certain places May 8, 2023
@morrisonlevi morrisonlevi merged commit bc95ae7 into master May 8, 2023
475 checks passed
@morrisonlevi morrisonlevi deleted the florian/enable-allocation-profiling-in-randomized-tests branch May 8, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees

@realFlowControl realFlowControl

Labels
cat:app-crash profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realFlowControl @morrisonlevi @bwoebi