Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the allocated heap size of the elasticsearch7 container #2040

Merged
merged 4 commits into from
May 9, 2023

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented May 9, 2023

Description

It sometimes happened that the elasticsearch7 container would exit with the error code 137 in the CI, but with the introduction of the SQLSRV integration and its additional container, elasticsearch would often exit, hence making the integrations tests fail.

This PR just changes the heap size of this container (or more specifically, the amount of memory the JVM is allowed to use), which is 2gb by default, to 1gb, which should be enough for testing purposes.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@PROFeNoM PROFeNoM added the ci label May 9, 2023
@PROFeNoM PROFeNoM added this to the 0.87.0 milestone May 9, 2023
@PROFeNoM PROFeNoM self-assigned this May 9, 2023
@PROFeNoM PROFeNoM requested a review from a team as a code owner May 9, 2023 16:27
@PROFeNoM PROFeNoM merged commit 6dd6fb9 into master May 9, 2023
309 of 461 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/elasticsearch7-ci-error branch May 9, 2023 16:33
@morrisonlevi
Copy link
Collaborator

I assume this fixes it because the container doesn't have 2GB of memory, so it gets OOM killed?

@PROFeNoM
Copy link
Contributor Author

PROFeNoM commented May 9, 2023

I assume this fixes it because the container doesn't have 2GB of memory, so it gets OOM killed?

The container would indeed get OOM killed (more information https://github.com/10up/wp-local-docker/issues/6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants