Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving hooks within files declaring many functions on PHP 7.2 - 8.1 #2045

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix resolving hooks within files declaring many functions on PHP 7.2 - 8.1 #2045

merged 1 commit into from
May 11, 2023

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented May 11, 2023

Description

For details, see php/php-src#11222, which uses the same broken underlying API

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug. ... Not really sure how to test that, it's hard to even trigger it.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.87.0 milestone May 11, 2023
@bwoebi bwoebi requested a review from a team as a code owner May 11, 2023 10:34
@bwoebi
Fix resolving hooks within files declaring many functions on PHP 7.2 …
b6368de 
…- 8.1

For details, see php/php-src#11222, which uses the same broken underlying API

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 666a86c into master May 11, 2023
337 of 342 checks passed
@bwoebi bwoebi deleted the bob/fix-funcpos branch May 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.87.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwoebi @realFlowControl