Do not force cycle collection at runtime on flush by default #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Comment on lines
-676
to
+675
| // We need to loop here, as closing the last span root stack could add other spans here | ||
| while (DDTRACE_G(top_closed_stack)) { | ||
| if (DDTRACE_G(top_closed_stack)) { |
There was a problem hiding this comment.
question: Is this comment not true anymore and is this related to not calling a garbage collection cycle?
There was a problem hiding this comment.
Yes, that's related to the garbage collection. The code in this function does not have any side effects by itself.
realFlowControl
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an user where it massively impacted their performance: And practically it should rarely make a difference (it only matters with autoflush active and forgetting to close all of a stacks spans and GC running next to never in a long running script. But if it does delay traces from arriving, there's an escape hatch configuration option.
Readiness checklist
Tests added for this feature/bug.Performance issue rather.Reviewer checklist