Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C extension PHP 5.4 support #205

Merged
merged 61 commits into from
Jan 21, 2019
Merged

C extension PHP 5.4 support #205

merged 61 commits into from
Jan 21, 2019

Conversation

pawelchcki
Copy link
Contributor

@pawelchcki pawelchcki commented Jan 2, 2019 •
edited
Loading

Description

Readiness checklist

labbati
labbati reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added minor comments more related to the syntax that semantics

docker-compose.yml Outdated Show resolved Hide resolved
src/ext/dispatch.c Outdated Show resolved Hide resolved
src/ext/dispatch.c Outdated Show resolved Hide resolved
@labbati labbati added this to the 0.9.0 milestone Jan 4, 2019
@labbati labbati added the c-extension Apply this label to issues and prs related to the C-extension label Jan 4, 2019
@pawelchcki pawelchcki force-pushed the support_php_5_4 branch 2 times, most recently from 784f0c7 to 0f5f074 Compare January 17, 2019 21:27
@pawelchcki
PHP 5.4 Initial version
8a79bfb 
better Makefile

 Make version undefined by default

Fix configure file compatibility
@pawelchcki
php 5.4 image build
5653292
@pawelchcki
Fix return value passing
efbe7b3
@pawelchcki
Add sudo and $(Q) prefix to makefile
100abac
@pawelchcki
Compile without optimizations
838e5a6
@pawelchcki
add zent_throw_internal
0953deb
@pawelchcki
Fix EX(object) being GC'ed early
40c67ca
@pawelchcki
Fix working stuff
1149315
@pawelchcki
Fix dispatch of FCALL without names
3e3a905
@pawelchcki
Fix memory corruption due to invalid current_this pointer
73066ee
@pawelchcki
Fix jump based on uninitialized variable
7de0b61
@pawelchcki
Remove memory leaks related to variable result returning
1d8712c
@pawelchcki
Safer function pointer lookup
9164076
@pawelchcki
Test Construct via reflection is working as expected
fa42486
@pawelchcki
Add dd_trace_noop function
ef503ec
@pawelchcki
Cleanup makefile and remove phpstan
730142d
@pawelchcki
Docker compose separate folder for vendor per php version
6ad92f6
@pawelchcki
Private self access tests
ec41a47
@pawelchcki
Add debug option to Makefile
c6f475f
@pawelchcki
WIP cleanup Makefile
4fa3344
@pawelchcki
Cleanup unused code
9466210
@pawelchcki
Cleanup + add Werror
3cf87f7
@pawelchcki
On the road to 5.4
a3177c8
@pawelchcki
Fix typo
5c85a74
labbati and others added 18 commits January 21, 2019 13:48
@labbati
Merge branch 'support_php_5_4' of github.com:DataDog/dd-trace-php int…
9ee555d 
…o labbati/fix-54-tests
@pawelchcki
docker compose add latest ddtrace_php_5_4 image
754e07f
@pawelchcki
Merge remote-tracking branch 'origin/labbati/fix-54-tests' into suppo…
6c3e138 
…rt_php_5_4
@labbati
[ci] Startup image to build 5.4 packages
d5be5a4
@labbati
[integrations] Disable flacky integrations in 5.4
518a282
@labbati
Merge branch 'support_php_5_4' of github.com:DataDog/dd-trace-php int…
6cf6b70 
…o labbati/fix-54-tests
@labbati
[ci] Fix static analysis
71b93a4
@labbati
[ci] Fix linting
791af49
@labbati
[ci] Fix extension build command
fc66340
@pawelchcki
Fix 5.6 return value handling
c6a8f79
@pawelchcki
Fix error in config.yml
83bce9d
@pawelchcki
PHP stan explicit install step
bc89774
@pawelchcki
PHP stan - where are you
7eed02d
@pawelchcki
PHPstan use global installation
d86b37c
@pawelchcki
Merge remote-tracking branch 'origin/labbati/fix-54-tests' into suppo…
16a709c 
…rt_php_5_4
@labbati
[ci] Fix package build
405b2ef
@labbati
[ci] Make phpstan exclude relative to the file
a316331
@labbati
[ci] do not use composer cache for 5.4
5a2ac5b
labbati
labbati approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, great work @pawelchcki

@pawelchcki pawelchcki merged commit 5347c1f into dev Jan 21, 2019
@pawelchcki pawelchcki deleted the support_php_5_4 branch January 21, 2019 17:59
@SammyK
Copy link
Contributor

SammyK commented Jan 22, 2019

Awesome work on this @pawelchcki! I know this was a beast and you totally rocked it! :D

@remicollet remicollet mentioned this pull request Jan 22, 2019
Closed
bwoebi pushed a commit that referenced this pull request Sep 15, 2023
@Anilm3
Parallel clang-tidy and helper valgrind test (#205)
ec8cc29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

Assignees

@pawelchcki pawelchcki

Labels
c-extension Apply this label to issues and prs related to the C-extension
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pawelchcki @SammyK @labbati