-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(profiling): use faster, persistent caching strategy #2316
Closed
+476
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't currently disable walltime profiles completely, it only cancells the timer. You can still trigger them manually.
BenchmarksBenchmark execution time: 2023-11-01 20:43:26 Comparing candidate commit 508fc72 in PR branch Found 6 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 3 unstable metrics. scenario:walk_stack/1
scenario:walk_stack/50
scenario:walk_stack/99
scenario:walk_stack_instructions/1
scenario:walk_stack_instructions/50
scenario:walk_stack_instructions/99
|
realFlowControl
approved these changes
Oct 16, 2023
morrisonlevi
changed the title
feat: add DD_PROFILING_WALLTIME_ENABLED
feat: add DD_PROFILING_WALLTIME_ENABLED for testing
Oct 18, 2023
realFlowControl
force-pushed
the
levi/overhead-bench
branch
from
October 19, 2023 18:45
3701053
to
4b3a7b3
Compare
morrisonlevi
changed the title
feat: add DD_PROFILING_WALLTIME_ENABLED for testing
perf(profiling): use persistent caching strategy
Oct 27, 2023
morrisonlevi
changed the title
perf(profiling): use persistent caching strategy
perf(profiling): use faster, persistent caching strategy
Oct 27, 2023
morrisonlevi
force-pushed
the
levi/overhead-bench
branch
from
October 30, 2023 14:58
a6541fb
to
194bc2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
DD_PROFILING_WALLTIME_ENABLED
which doesn't currently disable wall-time profiles completely, it only cancels the timer. You can still trigger them manually, which is partly the purpose: we want to disable automatic collection so we can benchmark in a controlled way.It then uses a new caching strategy which will speed up stack walking in two ways:
Readiness checklist
Reviewer checklist