Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extra arguments for internal overrideArgs #2348

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 6, 2023

Description

This fixes:

  • overrideArguments usage when changing a by-ref parameter
  • overrideArguments usage when optional arguments to internal functions are being set
  • properly handles freeing of garbage in overrideArguments for internal functions on PHP 8 when more arguments are provided than initially set.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.94.0 milestone Nov 6, 2023
@bwoebi bwoebi requested a review from a team as a code owner November 6, 2023 21:10
@bwoebi bwoebi force-pushed the bob/add-internal-args-overrideArgs branch from f29e9ef to 1589be2 Compare November 7, 2023 11:07
@bwoebi bwoebi force-pushed the bob/add-internal-args-overrideArgs branch from 1589be2 to 7adda81 Compare November 7, 2023 15:11
bwoebi and others added 4 commits November 7, 2023 18:07
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/add-internal-args-overrideArgs branch from 7adda81 to 2972dbf Compare November 7, 2023 17:07
@bwoebi bwoebi merged commit a1f35f6 into master Nov 8, 2023
554 of 558 checks passed
@bwoebi bwoebi deleted the bob/add-internal-args-overrideArgs branch November 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants