Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http_code instead of connect_time to detect curl errors #2391

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Use http_code instead of connect_time to detect curl errors #2391

merged 1 commit into from
Nov 28, 2023

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Nov 27, 2023 •
edited

Description

Fixes #2390.

The artifact was tested and appears to have solved the corresponding issue.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors, the reviewer is in charge of this task.

@PROFeNoM PROFeNoM added 🐛 bug Something isn't working tracing labels Nov 27, 2023
@PROFeNoM PROFeNoM self-assigned this Nov 27, 2023
@PROFeNoM PROFeNoM requested a review from a team as a code owner November 27, 2023 09:22
pierotibou
pierotibou approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests, no gain!

@PROFeNoM PROFeNoM merged commit 92d074e into master Nov 28, 2023
513 of 515 checks passed
@PROFeNoM PROFeNoM deleted the alex/issue/2390 branch November 28, 2023 15:24
@PROFeNoM PROFeNoM added this to the 0.94.1 milestone Nov 28, 2023
@realFlowControl realFlowControl modified the milestones: 0.94.1, 0.95.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotibou pierotibou pierotibou approved these changes

Assignees

@PROFeNoM PROFeNoM

Labels
🐛 bug Something isn't working tracing
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.

[Bug]: curl_multi_exec() request failure on 0.94.0
3 participants
@PROFeNoM @pierotibou @realFlowControl