Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement http.route for Slim #2402

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Implement http.route for Slim #2402

merged 9 commits into from
Jan 15, 2024

Conversation

pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Dec 4, 2023 •
edited

Description

Adds http.route to Slim integration

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pablomartinezbernardo pablomartinezbernardo changed the title Implement http.route for Slim [WIP] Implement http.route for Slim Dec 4, 2023
@pablomartinezbernardo pablomartinezbernardo changed the title [WIP] Implement http.route for Slim Implement http.route for Slim Dec 18, 2023
@pablomartinezbernardo pablomartinezbernardo marked this pull request as ready for review December 18, 2023 09:00
@pablomartinezbernardo pablomartinezbernardo requested a review from a team as a code owner December 18, 2023 09:00
PROFeNoM
PROFeNoM approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃 Sorry for the delay 👍

@pablomartinezbernardo pablomartinezbernardo merged commit 061882b into master Jan 15, 2024
520 of 522 checks passed
@pablomartinezbernardo pablomartinezbernardo deleted the slim-http-route branch January 15, 2024 08:43
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estringana estringana estringana left review comments

@bwoebi bwoebi bwoebi left review comments

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees
No one assigned
Labels
tracing
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablomartinezbernardo @estringana @bwoebi @PROFeNoM