Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): GA exception profiling #2403

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

realFlowControl
Copy link
Collaborator

@realFlowControl realFlowControl commented Dec 4, 2023

Description

This PR will GA exception profiling

Documented in DataDog/documentation#20880

PROF-8429

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Dec 4, 2023
@pr-commenter
Copy link

pr-commenter bot commented Dec 4, 2023

Benchmarks

Benchmark execution time: 2023-12-12 17:55:02

Comparing candidate commit 76f5b69 in PR branch florian/ga-exception-profiling with baseline commit 428a439 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@realFlowControl realFlowControl self-assigned this Dec 6, 2023
@realFlowControl realFlowControl added this to the future milestone Dec 6, 2023
@realFlowControl realFlowControl marked this pull request as ready for review December 6, 2023 15:41
@realFlowControl realFlowControl requested review from a team as code owners December 6, 2023 15:41
@github-actions github-actions bot removed this from the future milestone Dec 7, 2023
@morrisonlevi morrisonlevi added this to the 0.96.0 milestone Dec 12, 2023
@morrisonlevi morrisonlevi added the 🏆 enhancement A new feature or improvement label Dec 12, 2023
@morrisonlevi morrisonlevi changed the title feat(profiling) GA exception profiling feat(profiling): GA exception profiling Dec 12, 2023
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small thing, looks good otherwise.

datadog-setup.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, small spelling issue too.

datadog-setup.php Outdated Show resolved Hide resolved
datadog-setup.php Outdated Show resolved Hide resolved
realFlowControl and others added 3 commits December 12, 2023 18:46
Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
@github-actions github-actions bot removed this from the 0.96.0 milestone Dec 12, 2023
@realFlowControl realFlowControl merged commit ebbd19d into master Dec 13, 2023
406 of 410 checks passed
@realFlowControl realFlowControl deleted the florian/ga-exception-profiling branch December 13, 2023 10:00
@realFlowControl realFlowControl added this to the 0.96.0 milestone Dec 13, 2023
PROFeNoM pushed a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏆 enhancement A new feature or improvement profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants