Update datadog-setup.php #2417
Merged
Update datadog-setup.php #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8.3 was not in the list of supported versions. Which made it so that the installer script could only find the main binary /usr/bin/php because it didn't had a version number included in the path.
|
Hi @markwalet, Thanks for your contribution and for spotting this out. I'll accept your PR and add the tracer test suites (web/integrations) for PHP 8.3 as a PR on top of yours. Considering this may be business-critical for you and others, I assure you that this is at the top of my priority list, and I'll be working on it right away. |
PROFeNoM
added
🐛 bug
|
Thanks for the quick response. I've installed the trace library successfully now on PHP 8.3 and deployed it. It looks like php-fpm traces are coming in again. |
2 tasks
PROFeNoM
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
About the failing tests:
- System tests: Should pass, as can be seen on this equivalent branch
- Verify Alpine: Fixed by CI: Handle latest Alpine 3.19 image #2418 (Not related to this PR)
Thank you, @markwalet 😃
PROFeNoM
pushed a commit
that referenced
this pull request
Dec 15, 2023
8.3 was not in the list of supported versions. Which made it so that the installer script could only find the main binary /usr/bin/php because it didn't had a version number included in the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
8.3 was not in the list of supported versions. Which made it so that the installer script could only find the main binary /usr/bin/php because it didn't had a version number included in the path.
Reviewer checklist