-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiler) add exception message to exception sample #2434
Conversation
BenchmarksBenchmark execution time: 2024-02-19 11:14:01 Comparing candidate commit 486661c in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 50 unstable metrics. |
bb6bba4
to
ce9a920
Compare
2997629
to
1ab66ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any concerns about gathering the exception message? Any filtering or anything that needs done? I wonder if APM does anything.
@morrisonlevi I added an option to disable the collection of messages for exceptions. It is default enabled |
bce2feb
to
be802d6
Compare
be802d6
to
b62bd07
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2434 +/- ##
============================================
- Coverage 76.67% 76.65% -0.02%
Complexity 267 267
============================================
Files 136 136
Lines 17627 17629 +2
Branches 1034 1034
============================================
- Hits 13515 13514 -1
- Misses 3575 3578 +3
Partials 537 537
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@morrisonlevi I am btw. open to set this default disabled |
ddf48a3
to
93af3bc
Compare
93af3bc
to
9659084
Compare
Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
9659084
to
486661c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now :-)
Description
This will add the exception message to the sample that is taken. You'd need to opt-in to the collection of exception messages by setting the environment variable
DD_PROFILING_EXCEPTION_MESSAGE_ENABLED
or the INI settingdatadog.profiling.exception_message_enabled
totrue
/1
/on
.Additionally I moved reading the exception class name (and the message) to after the sampling decision which lowers the overhead of exception profiling.
PROF-8838
Reviewer checklist