Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(profiling): extract wall_time.rs file #2467

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Jan 12, 2024

Description

PROF-8912

Does two things:

  1. Extracts bits from lib.rs and capi.rs and puts them in a new wall_time.rs file.
  2. Uses ddog_php_prof_ instead of datadog_profiling_ for functions in wall_time.rs. This function is used by the tracer so it updates ext/engine_hooks.c too.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi marked this pull request as ready for review January 12, 2024 17:48
@morrisonlevi morrisonlevi requested review from a team as code owners January 12, 2024 17:48
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Jan 12, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 12, 2024

Benchmarks

Benchmark execution time: 2024-01-12 22:04:14

Comparing candidate commit 4f021ef in PR branch levi/wall-time with baseline commit b032b1e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 49 unstable metrics.

Copy link
Collaborator

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop Whoop

@realFlowControl realFlowControl merged commit ffeeba8 into master Jan 17, 2024
605 checks passed
@realFlowControl realFlowControl deleted the levi/wall-time branch January 17, 2024 07:44
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 17, 2024
@realFlowControl realFlowControl mentioned this pull request Jan 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants