Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer php compatibility declaration #247

Merged
merged 6 commits into from
Jan 22, 2019
Merged

Composer php compatibility declaration #247

merged 6 commits into from
Jan 22, 2019

Conversation

labbati
Copy link
Member

@labbati labbati commented Jan 22, 2019 •
edited

Description

Some parts of the docs were out of date. This PR fixes them

Readiness checklist

@labbati labbati changed the title [core] Fix readme and composer php compatibility Composer php compatibility declaration Jan 22, 2019
@labbati labbati added the 🍏 core Changes to the core tracing functionality label Jan 22, 2019
@labbati labbati added this to the 0.11.0 milestone Jan 22, 2019
SammyK
SammyK suggested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @labbati! Just two very tiny nit-picks and we're good to go! :D

docs/getting_started.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SammyK @labbati
Apply suggestions from code review
fad37da 
Co-Authored-By: labbati <luca.abbati@datadoghq.com>
SammyK
SammyK previously approved these changes Jan 22, 2019
View reviewed changes
SammyK
SammyK approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @labbati! :)

@labbati labbati merged commit 237e3b6 into master Jan 22, 2019
@labbati labbati assigned SammyK and unassigned SammyK Jan 22, 2019
@labbati labbati modified the milestones: 0.11.0, 0.10.1 Jan 23, 2019
@labbati labbati deleted the labbati/fix-readme branch February 7, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
🍏 core Changes to the core tracing functionality
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@labbati @SammyK