Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(profiling): fix clippy::single-match #2482

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Jan 19, 2024

Description

Fixes a clippy lint in the timeline feature of the profiler.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested a review from a team as a code owner January 19, 2024 17:53
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jan 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2024

Benchmarks

Benchmark execution time: 2024-01-19 17:59:57

Comparing candidate commit d6e0cc2 in PR branch levi/clippy-2024-01-19 with baseline commit 27335de in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Merging #2482 (d6e0cc2) into master (27335de) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2482      +/-   ##
============================================
- Coverage     79.42%   79.39%   -0.04%     
+ Complexity      267      216      -51     
============================================
  Files           109      102       -7     
  Lines         12863    12436     -427     
============================================
- Hits          10216     9873     -343     
+ Misses         2647     2563      -84     
Flag Coverage Δ
tracer-extension 79.36% <ø> (-0.06%) ⬇️
tracer-integrations 79.86% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27335de...d6e0cc2. Read the comment docs.

@realFlowControl realFlowControl merged commit de05e37 into master Jan 22, 2024
562 checks passed
@realFlowControl realFlowControl deleted the levi/clippy-2024-01-19 branch January 22, 2024 07:48
@github-actions github-actions bot added this to the 0.98.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants