Ensure logs are committed to disk upon shutdown #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2495 +/- ##
============================================
- Coverage 78.71% 76.96% -1.75%
Complexity 267 267
============================================
Files 110 136 +26
Lines 13191 17008 +3817
Branches 0 897 +897
============================================
+ Hits 10383 13090 +2707
- Misses 2808 3467 +659
- Partials 0 451 +451
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Anilm3
approved these changes
Jan 30, 2024
appsec/src/extension/logging.c
Outdated
| int errno_fsync; | ||
| int ret; | ||
| do { | ||
| fsync_ret = fsync(_mlog_fd); |
There was a problem hiding this comment.
Do you need to do fsync in the loop? Whether close was interrupted has no bearing on the outcome of fsync, although I guess it doesn't hurt either.
There was a problem hiding this comment.
yeah I guess i can move it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer checklist