Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking on PHP 7.0-7.1 ZTS #2502

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

cataphract
Copy link
Contributor

@cataphract cataphract commented Feb 1, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

APPSEC-51448

Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass...

@cataphract cataphract force-pushed the glopes/blocking-php-7.0-7.1-fix branch from 0566631 to 6965136 Compare February 2, 2024 08:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Merging #2502 (6965136) into master (679da8e) will decrease coverage by 1.79%.
The diff coverage is 56.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2502      +/-   ##
============================================
- Coverage     78.71%   76.92%   -1.79%     
  Complexity      267      267              
============================================
  Files           110      136      +26     
  Lines         13191    17018    +3827     
  Branches          0      903     +903     
============================================
+ Hits          10383    13091    +2708     
- Misses         2808     3471     +663     
- Partials          0      456     +456     
Flag Coverage Δ
appsec-extension 70.76% <56.25%> (?)
tracer-extension 78.66% <ø> (ø)
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
appsec/src/extension/commands/request_exec.c 100.00% <100.00%> (ø)
appsec/src/extension/commands/request_init.c 88.13% <100.00%> (ø)
appsec/src/extension/commands/request_shutdown.c 76.38% <100.00%> (ø)
appsec/src/extension/commands_helpers.c 68.91% <80.00%> (ø)
appsec/src/extension/request_abort.c 72.02% <25.00%> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679da8e...6965136. Read the comment docs.

@cataphract cataphract merged commit df13924 into master Feb 2, 2024
579 checks passed
@cataphract cataphract deleted the glopes/blocking-php-7.0-7.1-fix branch February 2, 2024 10:50
@github-actions github-actions bot added this to the 0.98.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants