Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PDO split-by coherent with other DB split-by with service name flattening #2524

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Feb 19, 2024

Split by should take priority in PDO integration over service name flattening

Fixes #2519.

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2024

Benchmarks

Benchmark execution time: 2024-02-19 16:53:03

Comparing candidate commit f5c6e88 in PR branch pmartinez/pdo-split-bugfix with baseline commit 09cb82a in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • BM_TeaSapiSpinup
  • BM_TeaSapiSpindown

Found 0 performance improvements and 1 performance regressions! Performance is the same for 42 metrics, 49 unstable metrics.

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+255.119ns; +661.781ns] or [+4.190%; +10.869%]

@pablomartinezbernardo pablomartinezbernardo marked this pull request as ready for review February 19, 2024 16:26
@pablomartinezbernardo pablomartinezbernardo requested a review from a team as a code owner February 19, 2024 16:26
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :-)

@bwoebi bwoebi merged commit 16386d4 into master Feb 19, 2024
526 of 544 checks passed
@bwoebi bwoebi deleted the pmartinez/pdo-split-bugfix branch February 19, 2024 17:11
@github-actions github-actions bot added this to the 0.98.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PDO/PHPRedis client split by instance inconsistency
2 participants