Ensure the permissions of the log file are actually really 0666 #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/umask-log-file
branch
from
a1b0f99
to
45e0e95
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2528 +/- ##
============================================
- Coverage 78.75% 76.55% -2.21%
Complexity 267 267
============================================
Files 112 138 +26
Lines 13482 17459 +3977
Branches 0 976 +976
============================================
+ Hits 10618 13365 +2747
- Misses 2864 3574 +710
- Partials 0 520 +520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-02-22 15:26:24 Comparing candidate commit a034ff8 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 180 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
|
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/umask-log-file
branch
from
45e0e95
to
a034ff8
Compare
bwoebi
added a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should probably ensure the sidecar doesn't fail spawning if the permissions of the log file don't match.
Reviewer checklist