Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DD_API_SECURITY_ENABLED flag #2532

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana force-pushed the estringana/add-api-security-enabled branch from 4a7d2d3 to 1e69c13 Compare February 22, 2024 14:35
@estringana estringana marked this pull request as ready for review February 22, 2024 16:54
@estringana estringana requested a review from a team as a code owner February 22, 2024 16:54
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample rate should not be removed, the new variable should be present in addition to the sample rate.

@estringana
Copy link
Contributor Author

The sample rate should not be removed, the new variable should be present in addition to the sample rate.

Done

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Merging #2532 (6a7683f) into master (b25dc1e) will decrease coverage by 2.19%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2532      +/-   ##
============================================
- Coverage     78.75%   76.56%   -2.19%     
  Complexity      267      267              
============================================
  Files           112      138      +26     
  Lines         13482    17454    +3972     
  Branches          0      976     +976     
============================================
+ Hits          10618    13364    +2746     
- Misses         2864     3570     +706     
- Partials          0      520     +520     
Flag Coverage Δ
appsec-extension 69.13% <100.00%> (?)
tracer-extension 78.71% <ø> (ø)
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
appsec/src/extension/commands/client_init.c 84.21% <100.00%> (ø)
appsec/src/extension/configuration.h 100.00% <ø> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25dc1e...6a7683f. Read the comment docs.

Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana merged commit 48ba7d7 into master Feb 27, 2024
586 of 593 checks passed
@estringana estringana deleted the estringana/add-api-security-enabled branch February 27, 2024 14:11
@github-actions github-actions bot added this to the 0.99.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants