Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5 4 installation and build #255

Merged
merged 7 commits into from
Jan 23, 2019
Merged

Fix 5 4 installation and build #255

merged 7 commits into from
Jan 23, 2019

Conversation

pawelchcki
Copy link
Contributor

@pawelchcki pawelchcki commented Jan 23, 2019 •
edited

Description

Readiness checklist

@pawelchcki pawelchcki force-pushed the fix_5_4_installation_and_build branch 2 times, most recently from 6ed33d6 to f888064 Compare January 23, 2019 15:23
@pawelchcki pawelchcki force-pushed the fix_5_4_installation_and_build branch 4 times, most recently from 9f72952 to 0e9b227 Compare January 23, 2019 15:34
@pawelchcki pawelchcki force-pushed the fix_5_4_installation_and_build branch from 0e9b227 to c83113f Compare January 23, 2019 15:34
@labbati labbati added this to the 0.10.1 milestone Jan 23, 2019
labbati
labbati approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I love the docker-compose approach! 🔝

dockerfiles/verify_packages/docker-compose.yml
x-aliases:
- &base_build
ulimits:
core: 99999999999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ let's go full everything 😄

dockerfiles/verify_packages/docker-compose.yml
@@ -0,0 +1,27 @@
version: '3.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the docker-compose approach 👍

@pawelchcki pawelchcki merged commit efe23a6 into master Jan 23, 2019
@pawelchcki pawelchcki deleted the fix_5_4_installation_and_build branch January 23, 2019 16:24
bwoebi pushed a commit that referenced this pull request Sep 15, 2023
@Anilm3
Upgrade WAF to 1.10.0 and add custom_rules capability (#255)
6900dc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pawelchcki @labbati