Configurable sampler #260
Merged
Configurable sampler #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
suggested changes
Jan 28, 2019
| @@ -101,7 +101,7 @@ public function reset() | |||
| { | |||
| $this->scopeManager = new ScopeManager(); | |||
| $this->globalConfig = Configuration::get(); | |||
| $this->sampler = new AlwaysKeepSampler(); | |||
| $this->sampler = new ConfigurableSampler(); | |||
Co-Authored-By: labbati <luca.abbati@datadoghq.com>
|
@SammyK up again for second round of CR |
SammyK
previously approved these changes
Jan 29, 2019
| $first31bits = mt_rand(0, mt_getrandmax()) << 32; | ||
| $second31bits = mt_rand(0, mt_getrandmax()) << 1; | ||
| $random1or0 = mt_rand(0, 1); | ||
| return (string) ($first31bits | $second31bits | $random1or0); |
There was a problem hiding this comment.
Nice workaround @labbati! For the future PR, we'll look into possibly supporting 32-bit architectures as well. :)
| */ | ||
| public static function getMaxId() | ||
| { | ||
| return (mt_getrandmax() << 32) | (mt_getrandmax() << 1) | 1; |
There was a problem hiding this comment.
I'm curious why this exists. Is it just to show that the return value is the same as PHP_INT_MAX in the tests? I don't see it being used anywhere else in the tracer and that test might break on 32-bit boxes. Just double checking. :)
| // algorithm. To compensate this we use here a `mt_rand` generate value to decide how to set the priority | ||
| // sampling. When we will introduce client sampling we will have to implement the real and final knuth hashing | ||
| // function. | ||
| $shouldKeep = mt_rand(1, mt_getrandmax()) <= $rate * mt_getrandmax(); |
SammyK
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow user to configure the sampling rate through an environmental variable
DD_SAMPLING_RATEwhich can be set as a floating point number between0.0(always reject) and1.0(always keep).Readiness checklist
Special kudos to @SammyK in the PR header to have spotted the 32/64 bits issue 😄