Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared compilation on macOS #2613

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix shared compilation on macOS #2613

merged 1 commit into from
Apr 4, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Apr 4, 2024

Description

Fix compilation of the rust crate on macOS when using the php_shared_build config option.

Error was:

  = note: Undefined symbols for architecture arm64:
            "_DDTRACE_MOCK_PHP", referenced from:
                _ddog_sidecar_connect_php in ddtrace_php.ddtrace_php.5b56db22beb5c715-cgu.0.rcgu.o
            "_DDTRACE_MOCK_PHP_SIZE", referenced from:
                _ddog_sidecar_connect_php in ddtrace_php.ddtrace_php.5b56db22beb5c715-cgu.0.rcgu.o
          ld: symbol(s) not found for architecture arm64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc changed the title Fix compilation on macOs Fix compilation on macOS Apr 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Merging #2613 (f93b642) into master (633c5ad) will decrease coverage by 1.96%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2613      +/-   ##
============================================
- Coverage     76.53%   74.57%   -1.96%     
  Complexity     2609     2609              
============================================
  Files           217      217              
  Lines         23318    23318              
============================================
- Hits          17846    17389     -457     
- Misses         5472     5929     +457     
Flag Coverage Δ
tracer-extension 78.70% <ø> (ø)
tracer-php 69.50% <ø> (-4.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633c5ad...f93b642. Read the comment docs.

@iamluc iamluc marked this pull request as ready for review April 4, 2024 14:47
@iamluc iamluc requested a review from a team as a code owner April 4, 2024 14:47
@bwoebi bwoebi merged commit 0d08bf6 into master Apr 4, 2024
292 of 401 checks passed
@bwoebi bwoebi deleted the lv/fix-compilation-macos branch April 4, 2024 15:06
@github-actions github-actions bot added this to the 0.100.0 milestone Apr 4, 2024
realFlowControl pushed a commit that referenced this pull request Apr 4, 2024
@bwoebi bwoebi changed the title Fix compilation on macOS Fix shared compilation on macOS Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants