Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 3.3 #266

Merged
merged 44 commits into from
Jan 29, 2019
Merged

Support for Symfony 3.3 #266

merged 44 commits into from
Jan 29, 2019

Conversation

labbati
Copy link
Member

@labbati labbati commented Jan 28, 2019

Description

This PR adds support for Symfony version 3.3

Readiness checklist

…e-php into labbati/improve-autoinstrumentation
@labbati labbati added this to the 0.11.0 milestone Jan 29, 2019
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question. Otherwise looks good 👍

CHANGELOG.md Outdated
@@ -3,8 +3,6 @@ All notable changes to this project will be documented in this file - [read more

## [UNRELEASED]

## [0.11.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add back, merging error probably :(

@labbati
Copy link
Member Author

labbati commented Jan 29, 2019

@pawelchcki thank you for the CR, I added back the missing header in the changelog 🙇

@labbati labbati merged commit 8c5c885 into master Jan 29, 2019
@labbati labbati deleted the labbati/symfony33-tests branch January 29, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants