Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritance bug when invoking parent:: in a subclass #284

Merged
merged 45 commits into from Apr 29, 2019
Merged

Fix inheritance bug when invoking parent:: in a subclass #284

merged 45 commits into from Apr 29, 2019

Conversation

SammyK
Copy link
Contributor

@SammyK SammyK commented Feb 4, 2019 •
edited

Description

A subclass that overwrites a parent method and invokes the parent method with parent:: will return the value of the subclass method (if it exists in the subclass) instead of the parent method. This is the root cause behind the bug caused by Drupal 7's DBAL.

Readiness checklist

@SammyK SammyK added 🐛 bug Something isn't working ☠️ do-not-merge/WIP 🍏 core Changes to the core tracing functionality c-extension Apply this label to issues and prs related to the C-extension labels Feb 4, 2019
@SammyK SammyK added this to the 0.13.0 milestone Feb 4, 2019
@SammyK SammyK self-assigned this Feb 4, 2019
@SammyK SammyK mentioned this pull request Feb 5, 2019
Merged
2 tasks
@labbati labbati modified the milestones: 0.13.0, 0.14.0, 0.15.0 Feb 12, 2019
This was referenced Feb 19, 2019
Closed
Merged
@SammyK SammyK force-pushed the sammyk/fix-inheritance-bug branch 3 times, most recently from f01e789 to abb08bc Compare February 25, 2019 14:30
@labbati labbati removed this from the 0.14.0 milestone Feb 26, 2019
@SammyK SammyK force-pushed the sammyk/fix-inheritance-bug branch 2 times, most recently from 04aa0d5 to 350ad2a Compare February 28, 2019 18:02
@SammyK SammyK force-pushed the sammyk/fix-inheritance-bug branch 2 times, most recently from f43e9af to 317815c Compare March 13, 2019 16:49
@SammyK SammyK force-pushed the sammyk/fix-inheritance-bug branch 2 times, most recently from df7ddb8 to 582c093 Compare April 19, 2019 15:39
@SammyK SammyK requested a review from pawelchcki April 22, 2019 17:00
@SammyK SammyK assigned pawelchcki and unassigned SammyK Apr 22, 2019
@SammyK SammyK requested a review from labbati April 22, 2019 17:01
@SammyK
Refactor TryCatchFinally into iinclude file for integrations except f…
ad013da 
…or Memcached
@SammyK
Support PHP 7.3
2d9019e
@SammyK
Prep for PHP 5 compat
57d4eed
@SammyK
Prep dispatch for PHP 5
f3c3bc4
@SammyK
Make boostrap code PHP 5 compat
a3b7a21
@SammyK
Add rough PHP 5.6 support
3facef7
@SammyK
Point to correct function handler for PHP 5.6 (sans args)
1420f03
@SammyK
Add context guard
cc6531f
@SammyK
Add null check to try-catch-finally shim
98138d4
@SammyK
Forward original function args in PHP 5.6
44bf702
@SammyK
Add safer way to jump out of include files in PHP 5.6
9f0f250
@SammyK
Fix linting
a2c6366
@SammyK
Add safer way to jump out of include files in PHP 7.2
bf995c6
@SammyK
Refactor how func_get_args() is handled in integrations
c424e54
@SammyK
Fix PHP 7.0 reference to undefined funcction
5b6278b
@SammyK
Update Integration::setDefaultTags() to reference the Span interface …
e910aac 
…so that the Noop span can be used
@SammyK
Fix segfault when pointing to wrong object pointer
40fbea4
@SammyK
Init function call structs with NULL to pass NULL assertion in PHP 7.0
361ff74
@SammyK
Fix wrong object pointer in PHP 5.4
d5ac17f
@SammyK
Update CHANGELOG
2843ebf
@SammyK
Remove commented out code in test
a08bf7e
@SammyK
Track function name instead of opline in PHP 5
18fb6ec
@SammyK SammyK force-pushed the sammyk/fix-inheritance-bug branch from 77cb752 to 18fb6ec Compare April 29, 2019 16:14
pawelchcki
pawelchcki approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SammyK SammyK merged commit 1c449b7 into master Apr 29, 2019
@SammyK SammyK deleted the sammyk/fix-inheritance-bug branch April 29, 2019 16:29
@emsearcy emsearcy mentioned this pull request Aug 22, 2019
Closed
@ajessu ajessu mentioned this pull request Mar 16, 2020
Closed
5 tasks
bwoebi pushed a commit that referenced this pull request Sep 15, 2023
@estringana
Release v0.12.0 (#284)
7e8c17c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelchcki pawelchcki pawelchcki approved these changes

@labbati labbati Awaiting requested review from labbati

Assignees

@pawelchcki pawelchcki

Labels
🐛 bug Something isn't working c-extension Apply this label to issues and prs related to the C-extension 🍏 core Changes to the core tracing functionality
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SammyK @pawelchcki @labbati