Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use more appropriate assertions #37

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Fix: Use more appropriate assertions #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Integration/Transport/HttpTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,6 @@ public function testSilentlySendTraces()
$httpTransport->send($traces);
$output = ob_get_clean();

$this->assertEmpty($output);
$this->assertSame('', $output);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to compare with an empty string, as

$this->assertEmpty('[]');

will pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could check strlen() also, but this is fine imo.

}
}
2 changes: 1 addition & 1 deletion tests/Unit/Encoders/JsonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function testEncodeTracesSuccess()

$jsonEncoder = new Json($logger->reveal());
$encodedTrace = $jsonEncoder->encodeTraces([[$span]]);
$this->assertEquals($expectedPayload, $encodedTrace);
$this->assertJsonStringEqualsJsonString($expectedPayload, $encodedTrace);
}

public function testEncodeIgnoreSpanWhenEncodingFails()
Expand Down