Adds tags and types. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
force-pushed
the
adds_tags_n_types
branch
from
ceef98a
to
00cecfa
Compare
jcchavezs
force-pushed
the
adds_tags_n_types
branch
from
00cecfa
to
648230b
Compare
palazzem
approved these changes
Feb 14, 2018
|
|
||
| const WEB_SERVLET = 'web'; | ||
|
|
||
| const SQL = 'sql'; |
There was a problem hiding this comment.
Just to let you know: this span.type is the most critical one. If it's set, the span.resource (that is a SQL query) will be obfuscated through the Agent filter and lexer: https://github.com/DataDog/datadog-trace-agent/blob/master/quantizer/main.go#L21-L30
No actions here, but in the future we should take it in consideration.
There was a problem hiding this comment.
Great feedback. This should be definitively in the description.
There was a problem hiding this comment.
What do you mean "obfuscated"? As in, it'll be removed from the trace?
There was a problem hiding this comment.
Replacing parameters with ? and similar - see https://github.com/DataDog/datadog-trace-agent/blob/master/obfuscate/sql.go. So that the same query with different parameters is recognized as the same and grouped, I believe.
|
|
||
| const ENV = 'env'; | ||
| const SPAN_TYPE = 'span.type'; | ||
| const SERVICE_NAME = 'service.name'; |
There was a problem hiding this comment.
What does service and resource name map to on the DataDog side of things?
There was a problem hiding this comment.
A service is a particular webapp, or maybe microservice, or a database. A resource is a particular query handled by that resource, like a path (/myaccount) or a query (select params from users where id = ?). See https://help.datadoghq.com/hc/en-us/articles/115000702546-What-is-the-Difference-Between-Type-Service-Resource-and-Name- for more.
|
Regarding SQL: Due to privacy issues and more important, to keep low
cardinality in tags it is recommended to store the parameters but wildcards
instead of the actual parameters.
Den ons. 25. jul. 2018, 19:58 skrev Chuck Hagenbuch <
notifications@github.com>:
***@***.**** commented on this pull request.
------------------------------
In src/DDTrace/Tags.php
<#4 (comment)>:
> @@ -0,0 +1,12 @@
+<?php
+
+namespace DDTrace\Tags;
+
+const ENV = 'env';
+const SPAN_TYPE = 'span.type';
+const SERVICE_NAME = 'service.name';
A service is a particular webapp, or maybe microservice, or a database. A
resource is a particular query handled by that resource, like a path
(/myaccount) or a query (select params from users where id = ?). See
https://help.datadoghq.com/hc/en-us/articles/115000702546-What-is-the-Difference-Between-Type-Service-Resource-and-Name-
for more.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7sAh5cBKbQTntllGIyEuSJ080nCOSXks5uKLHbgaJpZM4SAA_y>
.
--
*José Carlos*
|
iamluc
added a commit
that referenced
this pull request
May 27, 2024
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
#1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
#2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
#3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
#4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
#5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)
SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
iamluc
added a commit
that referenced
this pull request
May 27, 2024
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
#1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
#2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
#3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
#4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
#5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)
SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
bwoebi
added a commit
that referenced
this pull request
May 28, 2024
…nd trace sender (#2672) * Make use of the sidecar thread safe * Collect trace_api.{requests,responses,errors} in the background trace sender * Fix test * Fix memory leak: Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b) #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560 #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31 #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053 #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486 #5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b) SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s). * Update libdatadog * Fix tests * Try running system tests with sidecar sender Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Don't explicitly flush the bgs telemetry data * Improve test stability * Try to run system-tests from a fork * Fix telemetry tests * Shut up instrumentation telemetry in web tests * Fix flakiness Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Better flaky test check Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
tagsandtypes.Ping @palazzem