Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nette integration #504

Closed
wants to merge 2 commits into from
Closed

Conversation

kozaktomas
Copy link
Contributor

@kozaktomas kozaktomas commented Jul 22, 2019

Supported Nette framework versions:

  • 2.4 (PHP 5.6+)
  • 3.0 (PHP 7.1+)

Both versions are tested.

Integration is loaded after Nette\Configurator::__construct. It's one of the first object created in Nette.

Spans:

  • createContainer - dependency injection container creation
  • createRobotLoader - Nette framework autoloader
  • Application:run
  • Presenter:run - controller
  • Presenter:onError - error detection
  • Route:match - HTTP request router
  • createTemplate, render, renderToString Latte tempate engine - template name included

Closes #489

Readiness checklist

@kozaktomas kozaktomas force-pushed the nette-integration branch 2 times, most recently from 02b81b8 to 4a9d970 Compare July 23, 2019 07:29
@kozaktomas kozaktomas changed the title WIP Add Nette integration Add Nette integration Jul 23, 2019
@pawelchcki
Copy link
Contributor

Wow! Thanks for this awesome contribution @kozaktomas!
We'll take a closer look at it as soon as possible (although from the firce glance it looks very complete !!)

@kozaktomas
Copy link
Contributor Author

Hi @pawelchcki

I rebased my branch few times. It would be really nice to have it in the next version of this package. 🙏

@SammyK
Copy link
Contributor

SammyK commented Sep 16, 2019

Thank you so much for this awesome PR @kozaktomas! My apologies for the delay for a code review. I'll make sure to get this reviewed this week. :)

@SammyK SammyK added 🎉 new-integration A new integration 🏘 community Contributions from the general community labels Sep 16, 2019
SammyK
SammyK previously approved these changes Sep 20, 2019
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @kozaktomas! No changes required. I'm approving this now and will discuss with the team if we can get it merged for the next release. If not, we'll most likely merge it for the following release.

Thanks again for such a clean and feature-complete PR! ❤️

@SammyK
Copy link
Contributor

SammyK commented Sep 20, 2019

@kozaktomas We've got this slated for not the next release, but the release after that. That will give us some time to add the new Sandbox API to your awesome integration and then we can get it released. :)

@kozaktomas
Copy link
Contributor Author

Hi @SammyK. I did deeper testing (with agent) and I found a bug. I've added one additional commit. I also did rebase with master. Sorry for inconvenience. :)

@kozaktomas kozaktomas closed this Jan 8, 2020
@roman-vohnik
Copy link

Hi there!

I am trying DataDog APM with app based on Nette Framework right now and found this PR, why is it closed and not merged? It seems to me like it has already been almost done.

@SammyK
Copy link
Contributor

SammyK commented Jan 22, 2021

This was completely my fault for missing this for release so long ago. I'm sorry about that @kozaktomas.

@roman-vohnik This PR uses the legacy API for the integration which no longer ships with the tracer, but we should still be able to use the fantastic work @kozaktomas has already done and update it to use the sandbox API. Unfortunately we're not able to provide an ETA on when we will be able to refactor this at the moment, but I have added this to our internal project tracking and it is on our radar.

@SammyK
Copy link
Contributor

SammyK commented May 6, 2021

This PR for the Nette framework integration (#489) has been revived and merged via #1220 and will be included in the next release. Thank you again @kozaktomas for the original work on this and thank you @Anilm3 for reviving this PR. My apologies again for letting this PR slip through the cracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘 community Contributions from the general community 🎉 new-integration A new integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nette framework integration
4 participants