Address segmentation fault caused by accessing lookup data once the extension data was freed #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
force-pushed
the
pawel/build_fix_errors_found_in_tests
branch
from
b53d432
to
2c429f2
Compare
SammyK
suggested changes
Jul 23, 2019
There was a problem hiding this comment.
Very nice improvements @pawelchcki! I just suggested a few tweaks. :)
pawelchcki
force-pushed
the
pawel/build_fix_errors_found_in_tests
branch
from
8d8e709
to
b6fac9c
Compare
|
Thanks @SammyK for the review, I've addressed all suggestions. Should be ready for next review round. |
SammyK
previously approved these changes
Jul 24, 2019
pawelchcki
force-pushed
the
pawel/build_fix_errors_found_in_tests
branch
from
dd7872c
to
8a2944a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases PHP code could be run after extension destructor has run, causing a segmentation fault when accessing lookup data from within PHP code. This PR changes the code to use pointers to hashtables and sets them to NULL to denote they're not to be used. Additional checks have been added to lookup code to make sure we check the status of those pointers before accessing them.
Additionally this PR includes fixes for:
Readiness checklist