Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace count header only to PHP (subset of #522) #525

Merged
merged 2 commits into from Aug 8, 2019

Conversation

pawelchcki
Copy link
Contributor

Description

See PR #522 for more details

Readiness checklist

@pawelchcki pawelchcki changed the title Add trace count header only to PHP slimmed down PR #522 Add trace count header only to PHP (subset of #522) Aug 8, 2019
@pawelchcki pawelchcki force-pushed the pawel/add_trace_count_header_only_to_php branch from 6ca8beb to 6be7947 Compare August 8, 2019 10:03
@pawelchcki pawelchcki force-pushed the pawel/add_trace_count_header_only_to_php branch from 6be7947 to 574d0b1 Compare August 8, 2019 10:07
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this and on the investigation leading to this fix 😄

@pawelchcki pawelchcki merged commit 968655d into master Aug 8, 2019
@pawelchcki
Copy link
Contributor Author

Thanks for the review @labbati!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants