Correctly treat class names as case insensitive #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
added
🐛 bug
labbati
reviewed
Sep 13, 2019
| class_name = class->name; | ||
| class_name_length = class->name_length; | ||
| size_t class_name_length = class->name_length; | ||
| char *class_name = zend_str_tolower_dup(class->name, class_name_length); |
There was a problem hiding this comment.
Should we measure the impact of lowering every call? What do you think? Will it be noticeable?
There was a problem hiding this comment.
It's just a guess, but I think it will be okay. I'm not sure we can really avoid it -- the case insensitivity is PHP's behavior, which I'm sure we'll need to obey. In cases like CodeIgniter they definitely use the insensitivity as a feature, which is how I discovered this bug.
morrisonlevi
force-pushed
the
levi/case-insensitive-classes
branch
from
ba071c2
to
56dc131
Compare
SammyK
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PHP, class and method names are case insensitive. We already handled method names correctly. This PR adds support for case insensitive class names too.
Readiness checklist
Reviewer checklist