Migrate memcached integration to sandboxed API #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
added
🎉 new-integration
SammyK
suggested changes
Sep 18, 2019
|
|
||
| namespace DDTrace\Integrations\Memcached; | ||
|
|
||
| use DDTrace\Contracts\Span; |
There was a problem hiding this comment.
This isn't being referenced anywhere. :)
| $this->traceCommand('touch'); | ||
| $this->traceCommandByKey('touchByKey'); | ||
|
|
||
| dd_trace_method('Memcached', 'flush', function (SpanData $span, $args) use ($integration) { |
There was a problem hiding this comment.
The $args param can be removed :)
| */ | ||
| public function setServerTagsByKey(SpanData $span, $memcached, $key) | ||
| { | ||
| $server = $memcached->getServerByKey($key); |
There was a problem hiding this comment.
Since Memcached ::getServerByKey() can return false, can add a check on the return value? Something like:
if (!is_array($server)) {
return;
}I see this was migrated from the original integration so it would be great to update it there too. :)
labbati
force-pushed
the
labbati/sandboxing-memcached
branch
from
8de154e
to
0626bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the memcached integration to the new awesome sandboxed api.
Readiness checklist
Reviewer checklist